[PATCH] D50476: [NFC] ConstantMerge: don't insert when find should be used

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 10:37:45 PDT 2018


jfb added a comment.

In https://reviews.llvm.org/D50476#1197515, @dblaikie wrote:

> In https://reviews.llvm.org/D50476#1197511, @jfb wrote:
>
> > In https://reviews.llvm.org/D50476#1197364, @dblaikie wrote:
> >
> > > You could use D.count(V) to save the comparison with end, etc.
> >
> >
> > I don't understand what you're suggesting, could you clarify?
>
>
> Oh, read the code more - my mistake. Thought you were only testing for whether something was in the container - not actually having to use it afterwards. Carry on!


Ah OK! No worries, I thought *I* was having Monday-grogginess issues :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D50476





More information about the llvm-commits mailing list