[PATCH] D49512: [CodeGenPrepare] Add BothExtension type to PromotedInsts

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 09:28:31 PDT 2018


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Thanks for your patience.
LGTM.
One final nit below. Feel free to commit directly.



================
Comment at: test/Transforms/CodeGenPrepare/X86/multi-extension.ll:11
+; CHECK-NEXT:  %c = sext i16 %promoted to i64
+define i32 @foo(i16 %kkk) {
+entry:
----------------
Add a comment highlighting the characteristic of the test.
I.e., %or is reachable by both a sext and zext that are going to be promoted.


https://reviews.llvm.org/D49512





More information about the llvm-commits mailing list