[PATCH] D50494: [LLD] Reserve memory in implicitly set LMARegions

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 05:55:59 PDT 2018


ikudrin added inline comments.


================
Comment at: ELF/LinkerScript.cpp:774
+
+static bool isLMARegionCompatible(MemoryRegion *M, OutputSection *Sec) {
+  return (Sec->Type & SHT_NOBITS) || (M &&
----------------
There are neither existing nor new test cases which require this function and the corresponding condition. You may want to add the tests or, better, extract the check into a separate patch.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50494





More information about the llvm-commits mailing list