[PATCH] D50586: [Demangle] Add itaniumFindTypesInMangledName()

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

> I'll commandeer this so I can upload a patch with a test!
>  Add a test, libcxxabi changes.

Sure, thanks for adding this.

> Doing things this way, would require adding more hooks to the demangler, which does not seem particularly nice. OTOH, exposing the AST would allow other interesting uses too. ...

Yes, I am totally with you. Doing this on an exposed AST adds lots of potential, but it also seems like a bigger functional change to me, which requires proper planning and feature discussions. Thus, I am in favour of doing things step by step here. I'd first mimic the old LLDB behaviour with the new demangler and remove FastDemangle from LLDB. Afterwards we can plan and discuss at which places and for which extended functionality we can make use of an exposed AST.

In the meantime, I think `llvm::itaniumFindTypesInMangledName()` even adds value on its own as it's a simple way to visit parameter types in a mangled name.

What do you think?

> I've put up my work so far at https://reviews.llvm.org/D50599. It is still very WIP, but I believe it's enough to show the general direction of where I'm heading with this.

Thanks for sharing this! I will have a closer look asap.


https://reviews.llvm.org/D50586