[PATCH] D50490: Restore correct x86_64 EH encodings in kernel code model

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 15:34:23 PDT 2018


rnk added a comment.

Code looks good, but we should strengthen the test case.



================
Comment at: test/CodeGen/X86/code-model-kernel.ll:3
+; CHECK-LABEL: GCC_except_table0
+; CHECK: @TType Encoding = absptr
+; CHECK: .quad	_ZTIi
----------------
Please check all the relevant .cfi directives and the .byte that comes before this comment. For example, the number after .cfi_personalty should change as a result of this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D50490





More information about the llvm-commits mailing list