[PATCH] D50548: [CMake] Don't parse target triple except for arch

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 12:49:22 PDT 2018


phosek added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:297
+  list_sub(TARGET_TRIPLE_LIST 1 -1 TARGET_TRIPLE_SUBLIST)
+  string(REPLACE ";" "-" COMPILER_RT_DEFAULT_TARGET_TRIPLE_SUFFIX "${TARGET_TRIPLE_SUBLIST}")
   # Determine if test target triple is specified explicitly, and doesn't match the
----------------
phosek wrote:
> I'm not sure if `COMPILER_RT_DEFAULT_TARGET_TRIPLE_SUFFIX` is the best name for what this represents (triple without the arch portion) so I'm open to better suggestions if you have any.
I've done a bit more cleanup and this is no longer needed.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50548





More information about the llvm-commits mailing list