[PATCH] D50569: Change how we handle -wrap.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 11:05:03 PDT 2018


pcc added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1404-1407
+  for (InputFile *F : BinaryFiles)
+    Visit(F);
+  for (InputFile *F : BitcodeFiles)
+    Visit(F);
----------------
pcc wrote:
> I think you don't need to visit binary files because they do not contain relocations. Nor do you need to visit bitcode files because at this point they will have been replaced by real object files.
Looks like you're still visiting bitcode files.


https://reviews.llvm.org/D50569





More information about the llvm-commits mailing list