[PATCH] D50016: IR: Add entry/exit instrumentation symbols to the libcall list.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 09:41:27 PDT 2018


pcc added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:23
                        Instruction *InsertionPt, DebugLoc DL) {
+  // If you add code to recognize a new instrumentation function here, the
+  // function also needs to be added to include/llvm/IR/RuntimeLibcalls.def
----------------
tejohnson wrote:
> Can you include RuntimeLibcalls.def and assert that the name is in that list?
I could, but I don't think we need to do that unless there's evidence that people are ignoring the comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D50016





More information about the llvm-commits mailing list