[PATCH] D50560: [LLD] Enable Visual Studio compatible diagnostics.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 06:43:03 PDT 2018


ikudrin created this revision.
ikudrin added reviewers: chrisjackson, ruiu, inglorion.
ikudrin added a project: lld.
Herald added subscribers: MaskRay, arichardson, mgorny, emaste.
Herald added a reviewer: espindola.

This is an alternative implementation for https://reviews.llvm.org/D47540.

In this patch, I moved the code which produces the location part of a diagnostic message into a distinct place. I hope that this makes the overall code clearer because it simplifies other parts of the codebase.

The patch is primarily intended to demonstrate the approach and collect the feedback, which way we are going to go. The code is far from being perfect and has to be polished if this approach will be chosen.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50560

Files:
  Common/ErrorHandler.cpp
  ELF/CMakeLists.txt
  ELF/Diagnostics.cpp
  ELF/Diagnostics.h
  ELF/Driver.cpp
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/Options.td
  ELF/Relocations.cpp
  ELF/SymbolTable.cpp
  include/lld/Common/ErrorHandler.h
  test/ELF/Inputs/vs-diag-duplicate2.s
  test/ELF/Inputs/vs-diag-duplicate3.s
  test/ELF/vs-diag-duplicate.s
  test/ELF/vs-diag-dyn.s
  test/ELF/vs-diag-undef1.s
  test/ELF/vs-diag-undef2.s
  test/ELF/vs-diag-undef3.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50560.160099.patch
Type: text/x-patch
Size: 40595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180810/dbe1b1a1/attachment-0001.bin>


More information about the llvm-commits mailing list