[PATCH] D50518: [ARM] Disallow zexts in ARMCodeGenPrepare

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 06:26:45 PDT 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

These changes look reasonable to me.

The pass is still disabled by default, so this is a good opportunity (before we start thinking about flipping the switch again) to do more testing and get more experience with the pass without annoying others.



================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:482
   // TODO We should accept calls even if they don't have zeroext, as they can
   // still be roots.
   if (auto *Call = dyn_cast<CallInst>(V))
----------------
Some inconsistent terminology here (sources vs. roots), but this can be addressed in follow up patches.


https://reviews.llvm.org/D50518





More information about the llvm-commits mailing list