[PATCH] D50533: [MC] Move EH DWARF encodings from MC to CodeGen, NFC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 13:51:37 PDT 2018


rnk created this revision.
rnk added reviewers: davide, lliu0, JDevlieghere.
Herald added subscribers: fedor.sergeev, hiraditya.

The TType encoding, LSDA encoding, and personality encoding are all
passed explicitly by CodeGen to the assembler through .cfi_* directives,
so only the AsmPrinter needs to know about them.

The FDE CFI encoding however, controls the encoding of the label
implicitly created by the .cfi_startproc directive. That directive seems
to be special in that it doesn't take an encoding, so the assembler just
has to know how to encode one DSO-local label reference from .eh_frame
to .text.

As a result, it looks like MC will continue to have to know when the
large code model is in use. Perhaps we could invent a '.cfi_startproc
[large]' flag so that this knowledge doesn't need to pollute the
assembler.


https://reviews.llvm.org/D50533

Files:
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/Target/TargetLoweringObjectFile.h
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/Target/TargetLoweringObjectFile.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50533.159996.patch
Type: text/x-patch
Size: 18226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180809/7e0ea48b/attachment.bin>


More information about the llvm-commits mailing list