[PATCH] D50498: [LLD][ELF] - Fix crash when using empty --defsym.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 10:59:46 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Driver.cpp:1030
+      if (From.empty() || To.empty())
+        error("-defsym: syntax error");
+      else
----------------
Please include the option value itself as well:

"-defsym: syntax error: " + Arg->getValue()


https://reviews.llvm.org/D50498





More information about the llvm-commits mailing list