[PATCH] D50490: Pass code model parameter to MC from CodeGen

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 03:19:47 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

- I guess a possible alternative would have been to set LargeCodeModel to true for kernel case? Regardless, I'd prefer being explicit to prevent confusion.
- I'm slightly worried about the default value being `CodeModel::Small` in case other parts in MCObjectFileInfo start relying on this, but it's definitely the most sensible.

So all things considered this LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D50490





More information about the llvm-commits mailing list