[PATCH] D50343: [llvm-objcopy] Add support for -I binary -B <arch>.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In https://reviews.llvm.org/D50343#1190161, @rupprecht wrote:

> In https://reviews.llvm.org/D50343#1190050, @jakehehrlich wrote:
>
> > Ah so I think I'm against BinaryReader being templated against ELFT. That is required to implement getElfType() however. getElfType drives which writer we create. That shouldn't be how things work however. I'll go and add my related comments to this to the previous patch. Sorry if I didn't see what was going on in the other patch and lead you astray. This patch makes things a bit more clear.
>
>
> Yeah, it's not my first choice either, but it did make the implementation easier and seemed somewhat consistent with the pattern elsewhere in this file.


OK, I removed ELF templates from BinaryReader; having them remain on BinaryELFBuilder still seems appropriate though.


Repository:
  rL LLVM

https://reviews.llvm.org/D50343