[PATCH] D50203: Find PLT entries for x86, x86_64, and AArch64

Joel Galenson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 8 08:35:37 PDT 2018


jgalenson added inline comments.


================
Comment at: lib/Object/ELFObjectFile.cpp:357-360
+  const SectionRef *Plt = &*find_if(sections(), [&](const SectionRef &Sec) {
+    StringRef Name;
+    return !Sec.getName(Name) && Name == ".plt";
+  });
----------------
paulsemel wrote:
> As explained [[ https://reviews.llvm.org/D50204#inline-441914 | here ]], this is in my opinion not the right way to get the plt/got etc..
It seems like we decided over there to keep it this way.


Repository:
  rL LLVM

https://reviews.llvm.org/D50203





More information about the llvm-commits mailing list