[PATCH] D50440: [LLD] Add missing REQUIRES x86 to tests.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 8 05:45:41 PDT 2018


peter.smith created this revision.
peter.smith added reviewers: ruiu, grimar.
Herald added subscribers: dexonsmith, steven_wu, arichardson, emaste.
Herald added a reviewer: espindola.

Add REQUIRES to tests that fail when an x86 backend is not present.

There was a recent review https://reviews.llvm.org/D47748 to add REQUIRES x86 to all the tests that needed X86. Since that landed there have been a few new tests added without REQUIRES. We are going to remove the X86 backend from one of the linaro buildbots to speed it up and can keep the LLD tests up to date. The tests were identified by a run of the buildbot.

  FAIL: lld::guardcf-align.s
  FAIL: lld::icf16.s
  FAIL: lld::icf13.s
  FAIL: lld::icf15.s
  FAIL: lld::icf17.s
  FAIL: lld::libcall-archive.ll 


https://reviews.llvm.org/D50440

Files:
  test/COFF/guardcf-align.s
  test/ELF/icf13.s
  test/ELF/icf15.s
  test/ELF/icf16.s
  test/ELF/icf17.s
  test/ELF/lto/libcall-archive.ll


Index: test/ELF/lto/libcall-archive.ll
===================================================================
--- test/ELF/lto/libcall-archive.ll
+++ test/ELF/lto/libcall-archive.ll
@@ -1,3 +1,4 @@
+; REQUIRES: x86
 ; RUN: rm -f %t.a
 ; RUN: llvm-as -o %t.o %s
 ; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll
Index: test/ELF/icf17.s
===================================================================
--- test/ELF/icf17.s
+++ test/ELF/icf17.s
@@ -1,3 +1,4 @@
+# REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
 # RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
 
Index: test/ELF/icf16.s
===================================================================
--- test/ELF/icf16.s
+++ test/ELF/icf16.s
@@ -1,3 +1,4 @@
+# REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
 # RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
 
Index: test/ELF/icf15.s
===================================================================
--- test/ELF/icf15.s
+++ test/ELF/icf15.s
@@ -1,3 +1,4 @@
+# REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
 # RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
 
Index: test/ELF/icf13.s
===================================================================
--- test/ELF/icf13.s
+++ test/ELF/icf13.s
@@ -1,3 +1,4 @@
+# REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
 # RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
 
Index: test/COFF/guardcf-align.s
===================================================================
--- test/COFF/guardcf-align.s
+++ test/COFF/guardcf-align.s
@@ -1,3 +1,4 @@
+# REQUIRES: x86
 # RUN: llvm-mc -triple x86_64-windows-msvc -filetype=obj -o %t.obj %s
 # RUN: yaml2obj < %p/Inputs/guardcf-align-foobar.yaml \
 # RUN:     > %T/guardcf-align-foobar.obj


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50440.159691.patch
Type: text/x-patch
Size: 2048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180808/a80fc72d/attachment.bin>


More information about the llvm-commits mailing list