[llvm] r339169 - Update msbuild integration warnings: Don't warn on /Zi and /X

[Nico Weber via llvm-commits]

Author: nico
Date: Tue Aug  7 12:55:12 2018
New Revision: 339169

URL: http://llvm.org/viewvc/llvm-project?rev=339169&view=rev
Log:
Update msbuild integration warnings: Don't warn on /Zi and /X

We do need to map /Zi to /Z7 explicitly for msbuild as explained in this file,
but since /Zi is passed by default and since things transparently work fine
with it mapped to /Z7, we shouldn't produce effectively inactionable noise for
it.

Also don't warn on /X since clang-cl supports that (since r326357; the risk of
duplicating a bunch of clang-cl driver logic here).

https://reviews.llvm.org/D50398

Modified:
    llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets

Modified: llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets?rev=339169&r1=339168&r2=339169&view=diff
==============================================================================
--- llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets (original)
+++ llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets Tue Aug  7 12:55:12 2018
@@ -40,10 +40,7 @@
        to look at the tool output.
       -->
   <Target Name="BeforeClCompile" BeforeTargets="ClCompile">
-    <!-- Warn on /Zi and /ZI, then map them both to /Z7. -->
-    <Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'ProgramDatabase'"
-             File="@(ClCompile)(0,0)"
-             Text="clang-cl does not support /Zi (Program Database).  The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed.  Update the Debug Information Format in project settings to silence this warning."/>
+    <!-- Warn on /ZI, then map to /Z7. /Zi is mapped to /Z7 below too (see comment there), but don't warn on that. -->
     <Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'EditAndContinue'"
              File="@(ClCompile)(0,0)"
            Text="clang-cl does not support /ZI (Program Database for Edit and Continue).  The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed.  Update the Debug Information Format in project settings to silence this warning."/>
@@ -58,11 +55,6 @@
              File="@(ClCompile)(0,0)"
              Text="clang-cl does not support MSVC Link Time Optimization.  Disable this option in compatibility settings to silence this warning."/>
 
-    <!-- Warn if Ignore Standard Include Paths is non-empty, then ignore it. -->
-    <Warning Condition="'%(ClCompile.IgnoreStandardIncludePath)' == 'true'"
-             File="@(ClCompile)(0,0)"
-             Text="clang-cl does not support Ignore Standard Include Path (/X).  Disable this option in compatibility settings to silence this warning."/>
-
     <!-- Warn if Smaller Type Check is enabled, then ignore it.-->
     <Warning Condition="'%(ClCompile.SmallerTypeCheck)' == 'true'"
              File="@(ClCompile)(0,0)"