[PATCH] D50397: [lit, python3] Update lit error logging to work correctly in python3 and other test fixes

[Zachary Turner via llvm-commits]

No that’s fine, only makes sense to use it if it fits naturally. As long as
you tried. Lgtm as is
On Tue, Aug 7, 2018 at 2:11 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added a comment.
>
> In https://reviews.llvm.org/D50397#1191201, @zturner wrote:
>
> > We have a function somewhere in lit utils that does this, but I’m OOO so
> I
> >  can’t look for it. Can you try to find it?
>
>
> You are thinking of to_string in util.py. I could use it here, but the
> code in Test.py explicitly ignores any errors from the encode/decode calls
> while to_string raises an exception when it fails to encode. I could modify
> to_string to take an optional parameter to determine whether to raise an
> exception instead of having some of the same functionality in Test.py.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D50397
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180807/5444995b/attachment.html>