[PATCH] D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API

[Jakob Bornecrantz via Phabricator via llvm-commits]

Wallbraker added a comment.

In https://reviews.llvm.org/D35077#1191123, @hans wrote:

> In https://reviews.llvm.org/D35077#1190945, @xbolva00 wrote:
>
> > In https://reviews.llvm.org/D35077#1190698, @Wallbraker wrote:
> >
> > > Can this please please please be pushed ASAP so it can go in to the 7.0 release?
> >
> >
> > ask @hans if he can merge it to 7.0 branch :)
>
>
> I'd prefer not to merge it. Since this is a new feature that's been in the pipe for over a year, I don't think we should rush it in now. It would be better to let it land safely on trunk, get any kinks worked out and then have it be part of the next release.
>
> We should also check whether this will become part of the installer automatically, you can see how its built in utils/release/build_llvm_package.bat, or if that needs some update.


Ok that make sense!

@hans Right now it is not built by default, but I would be very happy to change that as that will give the change much more coverage. So either we would need to change build_llvm_package.bat to include that option or change the default.

Also you can break bat lines up similar to bash ones with `^` which might make the cmake command a bit more readable.


Repository:
  rL LLVM

https://reviews.llvm.org/D35077