[PATCH] D50394: [MS Demangler] Properly handle backreferences of special names

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 10:33:58 PDT 2018


majnemer added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:1416
     return demangleOperatorName(MangledName);
-  return demangleSimpleName(MangledName, Memorize);
+  return demangleSimpleName(MangledName, !!(NBB & NBB_Simple));
 }
----------------
majnemer wrote:
> `(NBB & NBB_Simple) == 0` isn't too many more characters and looks less weird.
Er, that should be `(NBB & NBB_Simple) != 0`


https://reviews.llvm.org/D50394





More information about the llvm-commits mailing list