[PATCH] D49727: [CodeGen] emit inline asm clobber list warnings for reserved

[Ties Stuij via Phabricator via llvm-commits]

stuij added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:566
+    SrcMgr.PrintMessage(Loc, SourceMgr::DK_Warning, Msg);
+    SrcMgr.PrintMessage(SMLoc(), SourceMgr::DK_Note, Note);
+  }
----------------
efriedma wrote:
> Doesn't the note need the same location to print correctly?
With a clean SMLoc, the note doesn't contain line info. I thought that was cleaner than adding line info. This way it's more obvious on sight that the note is explaining something about the warning. 

But thinking about it a bit more, it is a bit idiosyncratic. Changed to regular behavior in this patch.


https://reviews.llvm.org/D49727