[PATCH] D50322: Bitcode tests failure because of the change in r338787

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 09:36:13 PDT 2018


Meinersbur added a comment.

Looks like an obvious change, but r338787 is by @MatzeB I'd wait for his ok.



================
Comment at: Bitcode/Benchmarks/Halide/bilateral_grid/CMakeLists.txt:8-9
+llvm_multisource(halide_bilateral_grid
+${CMAKE_CURRENT_SOURCE_DIR}/driver.cpp 
+${bcsources}
+)
----------------
[nit] Can you indent the argument lines?


================
Comment at: Bitcode/simd_ops/CMakeLists.txt:22
   string(REPLACE "." "" namebc ${namebc})
-  set(Source ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_halide_runtime.bc ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_tests/${namebc}.bc ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_scalar_tests/scalar_${namebc}.bc)
-  llvm_multisource(simd_ops_${namebc})
+   llvm_multisource(simd_ops_${namebc}
+    ${CMAKE_CURRENT_SOURCE_DIR}/simd_ops.cpp
----------------
[nit] Indention is a bit off


Repository:
  rT test-suite

https://reviews.llvm.org/D50322





More information about the llvm-commits mailing list