[PATCH] D50238: [ARM] FP16: support the vector vmin and vmax variants

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:1140
     setOperationAction(ISD::FMINNAN, MVT::f16, Legal);
     setOperationAction(ISD::FMAXNAN, MVT::f16, Legal);
     setOperationAction(ISD::FMINNAN, MVT::f32, Legal);
----------------
efriedma wrote:
> Maybe not actually a part of this patch, but how does this work without hasFullFP16()?
At the moment, it doesn't unfortunately and we get:

  LLVM ERROR: Do not know how to split the result of this operator!

So yes, we need to address that too.


https://reviews.llvm.org/D50238