[PATCH] D45437: Support inline asm with multiple 64bit output in 32bit GPR

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7793
+      SDValue Val = ResultValues[i];
+      if (ResultTypes[i]->isSized()) {
+        // If the type of the inline asm call site return value is different but
----------------
efriedma wrote:
> isSized()?  How can you end up with an unsized value here?
It was in the original code so I kept it. I've now changed it to an assert and can confirm the testsuite shows no regression.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7813
+          // relevant portion.
+          Val = DAG.getNode(ISD::TRUNCATE, getCurSDLoc(), ResultVT, Val);
+        }
----------------
efriedma wrote:
> This part of the patch is just whitespace changes?
The comment yes, the rest is s/ResultType/ResultVT


Repository:
  rL LLVM

https://reviews.llvm.org/D45437