[PATCH] D50169: [XRay] Improve error reporting when loading traces

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 21:35:26 PDT 2018


dberris added a comment.

Thanks, I considered doing something like that, but it turns out a more principled refactoring makes it easier to reduce the requirement to wrap the data extractor API. It also turns out that we can make this simpler by extracting the "parsing" and validation logic out from the loading/reading logic, and operating at a higher level. I'm close to getting these parts re-written, where I may be able to do something like you're suggesting, but at a more fundamental level.


https://reviews.llvm.org/D50169





More information about the llvm-commits mailing list