[PATCH] D50310: Improve the legalisation lowering of UMULO

[Simonas Kazlauskas via Phabricator via llvm-commits]

nagisa updated this revision to Diff 159383.
nagisa added a comment.
Herald added subscribers: the_o, brucehoult, MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, asb, fedor.sergeev, aheejin, jgravelle-google, sbc100, nemanjai, jyknight, dschuff.

I’ve added some codegen tests. Those just ensure that targets are able to lower this operation more than anything else, although I did manually verify the x64 assembly to check whether it really looks like what I expect.

I would very much love to add a test that actually executes some machine code with a number of test vectors, but I believe no such test family exists in LLVM.


https://reviews.llvm.org/D50310

Files:
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  test/CodeGen/ARM/muloti2.ll
  test/CodeGen/PowerPC/muloti2.ll
  test/CodeGen/RISCV/muloti2.ll
  test/CodeGen/SPARC/muloti2.ll
  test/CodeGen/Thumb2/muloti2.ll
  test/CodeGen/WebAssembly/muloti2.ll
  test/CodeGen/X86/muloti.ll
  test/CodeGen/X86/muloti2.ll
  test/CodeGen/X86/select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50310.159383.patch
Type: text/x-patch
Size: 70995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180806/7ac42572/attachment-0001.bin>