[PATCH] D50268: [LLD] [COFF] Remove a superfluous warning about aligncomm for non-common symbols

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 10:56:07 PDT 2018


mstorsjo added inline comments.


================
Comment at: test/COFF/common-replacement.s:32-35
+# This produces an aligncomm directive, but when linking in
+# Inputs/common-replacement.s, this symbol is replaced by a normal defined
+# symbol instead.
+        .comm           foo, 4, 2
----------------
rnk wrote:
> Wow, our assembler does that? Crazy. Does gas?
Yes, so it seems. Good that the behaviour happens to match, however strange it is...


https://reviews.llvm.org/D50268





More information about the llvm-commits mailing list