[PATCH] D50335: vs integration: fix default path to clang-cl

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In https://reviews.llvm.org/D50335#1189459, @zturner wrote:

> Btw, unfortunately i had a few more changes to the csproj file that I may
>  have forgotten to upstream before i left. IIRC, they were changing the
>  author name to LLVMExtensions , deleting the part in the csproj about
>  Brutal Strong name signer, setting the key file in project settings, and
>  fixing the path to sn.exe.


Ouch, it's not so great that the published extension was built from source that's not checked in. But I guess publishing an updated version can wait until you're back.

In https://reviews.llvm.org/D50335#1189459, @zturner wrote:

> Edit: just saw your update. That is such weird installer behavior. What
>  goes in the LLVM key above that? Maybe the installer behavior changed and
>  we need to support both?


I tried an old installer (3.8.0) and it sets the same registry keys.

I don't know if it's that weird. I think cmake/cpack just figures the package vendor is LLVM and the product is also called LLVM, and that's how it ended up there.


https://reviews.llvm.org/D50335