[PATCH] D50323: [GVNHoist] Prune out useless CHI insertions

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 06:28:55 PDT 2018


labrinea added inline comments.


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:792
       // Make a map of BB vs instructions to be hoisted.
       for (unsigned i = 0; i < V.size(); ++i) {
         InValue[V[i]->getParent()].push_back(std::make_pair(VN, V[i]));
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > unsigned i = 0, e = V.size(); i < e; ++i
> > 
> > 
> > same below
> or better if possible.. for (auto &I : V) ?
Seems a nit and irrelevant to my changes, but I could do that.


https://reviews.llvm.org/D50323





More information about the llvm-commits mailing list