[PATCH] D50206: [lit, windows] Fix several lit tests on Windows

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 10:24:38 PDT 2018


stella.stamenova added a comment.

I looked at doing this in a generic way when we first encountered it and I couldn't find a good way of doing it partially because configuration files (such as lit.cfg in this changeset) can override the substitutions.

A couple of things we can do:

1. Update the cfg files as much as possible rather than the test themselves
2. Update config.py (where we define the default substitusions for tools) to use quotes as well.

One of the problems I originally ran into was that when the tool has inputs, putting quotes around the tool AND the input caused more problems. I think 2) will avoid that, but it's still not entirely generic and some tests might need individual fixes.

Let me know if you'd prefer that I try to update config.py as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D50206





More information about the llvm-commits mailing list