[PATCH] D48879: [XRay][test-suite] Benchmarks for profiling mode implementation

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 02:19:08 PDT 2018


dberris added a comment.

In https://reviews.llvm.org/D48879#1186974, @hans wrote:

> In https://reviews.llvm.org/D48879#1186442, @dberris wrote:
>
> > Hi Hans,
> >
> > I *think* this could be caused by the process running the tests
> >  exhausting available RAM (if this is running in a container with
> >  limited memory availability). I'll need to look into this deeper.
>
>
> Yes, that would make sense. I'm also not very familiar with how test-suite runs, but I think it uses a python virtualenv, and maybe that limits the amount of RAM available?


That's plausible.

>> I'm OK with running them sequentially, or even just limiting the
>>  number of threads in the benchmarks to reduce the requirements on
>>  available system memory.
> 
> I'm not sure if there's a way to make lit run them sequentially, unless they're turned into a single test executable. If making the benchmarks less "heavy" works, maybe that's the way to go.

I think doing both things makes sense. I'll merge them into a single binary and reducing the number of threads being executed.

Let me try something, and get you a patch to clean this up.


Repository:
  rL LLVM

https://reviews.llvm.org/D48879





More information about the llvm-commits mailing list