[PATCH] D26240: [LLD][ARM][AArch64] ARM and AArch64 undefined weak reference values for relative relocations

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 06:35:22 PDT 2018


grimar added inline comments.
Herald added subscribers: chrib, kristof.beyls, arichardson, emaste.
Herald added a reviewer: javed.absar.
Herald added a reviewer: espindola.


================
Comment at: lld/trunk/ELF/InputSection.cpp:266
+  case R_ARM_THM_JUMP11:
+    return P + 2;
+  case R_ARM_CALL:
----------------
I just noticed that we have now the next code here:

```
  case R_ARM_THM_JUMP11:
    return P + 2 + A;
```

And it seems it is uncovered by any test case we have now, in 2018.
Reporting just in case. (I do not know ARM enough to add a test, unfortunately)


Repository:
  rL LLVM

https://reviews.llvm.org/D26240





More information about the llvm-commits mailing list