[PATCH] D49395: [WebAssembly] Support for atomic.wait / atomic.wake instructions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 17:51:29 PDT 2018


aheejin added a comment.

I added `MOVolatile` flags to instructions, because, currently LLVM atomic instructions are marked as such. Reference: 1 <https://github.com/llvm-mirror/llvm/blob/1c8763a4dceb2025ac5c958603b2aedbbcd4763a/lib/CodeGen/SelectionDAG/SelectionDAG.cpp#L6028-L6031> 2 <https://github.com/llvm-mirror/llvm/blob/1c8763a4dceb2025ac5c958603b2aedbbcd4763a/lib/CodeGen/SelectionDAG/SelectionDAG.cpp#L6065-L6067>
I also added some comments on why `wake` is marked as `MOLoad`. PTAL


Repository:
  rL LLVM

https://reviews.llvm.org/D49395





More information about the llvm-commits mailing list