[PATCH] D49994: Allow constraining virtual register's class within reason

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 10:30:46 PDT 2018


uweigand added a comment.

In https://reviews.llvm.org/D49994#1184515, @alexey.zhikhar wrote:

> In https://reviews.llvm.org/D49994#1184441, @uweigand wrote:
>
> > The new code for f2 in cond-move-03.ll is in fact better, since it now actually uses the conditional move instruction instead of a branch ...
>
>
> Thanks, Ulrich. Does it fix `FIXME: We should commute the LOCRMux to save one move.` or is it unrelated?


It doesn't so much fix it, as make it no longer applicable.  Given that we use the hi->hi conditional move, we must have a lo->hi move (the risbgh) anyway in this constellation.

So in short, yes, you can remove the fixme now :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D49994





More information about the llvm-commits mailing list