[PATCH] D50121: [PowerPC] Do not round values prior to converting to integer

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 18:07:35 PDT 2018


hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:11702
       SDValue In = N->getOperand(i).getOperand(0);
-      // For 32-bit values, we need to add an FP_ROUND node.
+      // For 32-bit values, we need to add an FP_ROUND node (if we made it here,
+      // we know that all inputs came from an extending load so this is safe).
----------------
Can you move this comment into the Is32Bit if block below? You say, "if we made it here, ...", but that actually only applies if Is32Bit is true.


Repository:
  rL LLVM

https://reviews.llvm.org/D50121





More information about the llvm-commits mailing list