[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 15:31:45 PDT 2018


plotfi marked 3 inline comments as done.
plotfi added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:1272
 
+  bool IsGnuStyle = (CompressDebugSections == DebugCompressionType::GNU);
+  bool doCompress = (CompressDebugSections != DebugCompressionType::None) &&
----------------
jhenderson wrote:
> Why not just pass the compression style into the function directly? That way, we can add further methods later on.
I'm not sure what you mean? I do pass IsGnuStyle.


Repository:
  rL LLVM

https://reviews.llvm.org/D49678





More information about the llvm-commits mailing list