[PATCH] D50077: [LLD][ELF][ARM] Add support for Armv5 and Armv6 compatible Thunks

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 13:58:27 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:1463
+      // Adjust thunk section spacing to match shorter Thumb BL range.
+      Target->ThunkSectionSpacing = 0x400000 - 0x7500;
     // FIXME: These warnings can be removed when lld only uses these features
----------------
Currently, target is essentially a read-only object which only its constructor can initialize its members. So, if this needs to be a variable, can you define a function that returns an appropriate value, instead of precompute a value and mutate the Target member?


https://reviews.llvm.org/D50077





More information about the llvm-commits mailing list