[PATCH] D50081: [ValueTracking] fix maxnum miscompile for cannotBeOrderedLessThanZero (PR37776)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 12:35:09 PDT 2018


arsenm added a comment.

The nan, nan case may be constant folded, but I think this still needs to handle it correctly. A pass could still ask this on a call that hasn't been folded yet (although I guess this can't really be relied on for correctness anyway). The nan && nan case at least needs a comment


https://reviews.llvm.org/D50081





More information about the llvm-commits mailing list