[PATCH] D50033: Introduce DebugCounter into DevRemPairs pass

Zhizhou Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 10:45:15 PDT 2018


zhizhouy added a comment.

In https://reviews.llvm.org/D50033#1182317, @spatel wrote:

> Can you add a comment to the test file to explain what is happening there? I think we've specified that we will skip the 1st test, perform the transform on the 2nd test, and then perform no other transforms? Should there be a 4th function to verify that last case?


Comment added. Yes, your explanation is correct according to the link <http://llvm.org/docs/ProgrammersManual.html#adding-debug-counters-to-aid-in-debugging-your-code>.

And I also modified the test a little bit so that it will reflect more of transformation level than function level optimization.


Repository:
  rL LLVM

https://reviews.llvm.org/D50033





More information about the llvm-commits mailing list