[PATCH] D49547: [ELF] - Get rid of postThunkContents().

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Looks reasonable to me. I've made a suggestion that might simplify a bit further, I've not tried or tested it though.

Apologies for the late response; I've had this stuck in a draft state for a while, must have forgotten to press submit.



================
Comment at: ELF/SyntheticSections.cpp:1822
 
-  if (this->Type != SHT_DYNSYM)
+  if (this->Type != SHT_DYNSYM) {
+    sortSymTabSymbols();
----------------
If the only line of code that SymbolTableSection (SHT_SYMTAB) and SymbolTableBaseSection (SHT_DYNSYM) share is getParent()->Link ... Would it be possible to move sortSymTabSymbols into SymbolTableSection::finalizeContents() add the getParent()->Link and let the virtual call mechanism replace the test?


https://reviews.llvm.org/D49547