[PATCH] D50030: [ARM] Adjust AND immediates to make them cheaper to select.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 05:13:50 PDT 2018


samparker added a comment.

Hi Eli,

Would you mind adding a test case, perhaps similar to i16_cmpz, for the uxtb case? Also, I can see there's a test case for bic with -256, but I'm not sure about -2.. so could you also add that edge case as well?

thanks,



================
Comment at: test/CodeGen/ARM/Windows/vla.ll:17
 ; CHECK-SMALL-CODE:   adds [[R4:r[0-9]+]], #7
-; CHECK-SMALL-CODE:   bic [[R4]], [[R4]], #7
+; CHECK-SMALL-CODE:   bic [[R4]], [[R4]], #4
 ; CHECK-SMALL-CODE:   lsrs r4, [[R4]], #2
----------------
Just a bug in the existing test case?


Repository:
  rL LLVM

https://reviews.llvm.org/D50030





More information about the llvm-commits mailing list