[PATCH] D49937: [ARM] Allow automatically deducing the thumb instruction size for .inst

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 03:24:47 PDT 2018


peter.smith added a comment.

That looks like the right behaviour to me. For reference the Arm ARM definition of Thumb Instruction width from encodeing is in https://developer.arm.com/products/architecture/cpu-architecture/a-profile/docs/ddi0406/latest/arm-architecture-reference-manual-armv7-a-and-armv7-r-edition 6.1 Thumb Instruction set encoding.



================
Comment at: test/MC/ARM/inst-thumb-suffixes-auto.s:1
+@ RUN: llvm-mc %s -triple armv7-linux-gnueabi -filetype asm -o - \
+@ RUN:   | FileCheck %s
----------------
Would be good to add a test with triple armebv7-linux-gnueabi, my understanding is that the .inst and CHECK should remain the same.


Repository:
  rL LLVM

https://reviews.llvm.org/D49937





More information about the llvm-commits mailing list