[PATCH] D49972: [XRay][compiler-rt] FDR Mode: Use mmap instead of internal allocator

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 29 22:45:34 PDT 2018


dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_buffer_queue.cc:24
+// no-op on NetBSD (at least), unsupported flag on FreeBSD
+#define MAP_NORESERVE 0
+#endif
----------------
devnexen wrote:
> Wout it be useful to "refactor" it somewhere as it s already present in away_allocator ?
It could be, I suspect it's something worth doing in `sanitizer_common/sanitizer_posix.h` instead. Can do that as a follow-up.


https://reviews.llvm.org/D49972





More information about the llvm-commits mailing list