[PATCH] D49963: Preliminary patch to support prompt interpolation

[Neal via Phabricator via llvm-commits]

nealsid created this revision.
Herald added subscribers: llvm-commits, mgorny.

The infrastructure for interpolating format strings for the stacks and frames is very useful, so I thought it would also be useful to support this in interpolating the prompt string.  So you can define a prompt like this:

  (lldb) settings set prompt "${process.file.basename} T:${thread.index}/${thread.count} F:${frame.index1based}/${frame.count}) "

And the next prompt would be something like this:

  casn T:1/1 F:1/1) 

This is very preliminary as I am new to the LLDB code base, so I would welcome any and all feedback and suggestions. I plan to write tests and flesh out the error handling but wanted to get some eyes on this to help guide the remainder of the work, if people think it's useful. If not, I'm happy to tackle something else that could be more useful to the project.


Repository:
  rL LLVM

https://reviews.llvm.org/D49963

Files:
  include/lldb/Core/FormatEntity.h
  include/lldb/Core/IOHandler.h
  include/lldb/Host/Editline.h
  include/lldb/Interpreter/PromptInterpolation.h
  source/Core/FormatEntity.cpp
  source/Core/IOHandler.cpp
  source/Host/common/Editline.cpp
  source/Interpreter/CMakeLists.txt
  source/Interpreter/PromptInterpolation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49963.157882.patch
Type: text/x-patch
Size: 13342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180729/1f2b77ee/attachment.bin>