[PATCH] D48283: [SCEV] Properly solve quadratic equations

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 28 14:59:20 PDT 2018


sanjoy added a comment.

I didn't review the math, but I think there are some easy steps we can take to make this more watertight.  Firstly, the code that operates purely on `APInt` should be moved to `APInt.h`.  With that, we should be able to brute-force all possible inputs for a small bitwidth (`i3` or `i4`) and check that the solutions are correct.  What do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D48283





More information about the llvm-commits mailing list