[PATCH] D48828: [InstSimplify] fold extracting from std::pair

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D48828#1179348, @lebedev.ri wrote:

> In https://reviews.llvm.org/D48828#1179343, @inouehrs wrote:
>
> > > Why does the code use isa<ConstantInt> rather than match(op, m_APInt(C))? Using the matcher would give us vector splat functionality for free IIUC.
> >
> > Fixed. Thank you for the suggestion.
>
>
> I'm not sure of the exact problem (vector tests needed?), but added one nit.


Yes - I think we should have at least 1 minimal test with vector types for each transform, so we know if that's working as expected. I think it will work, but I haven't stepped through to confirm that.


https://reviews.llvm.org/D48828