[PATCH] D49919: [InstCombine] Fold Select with AND/OR condition

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 28 06:31:22 PDT 2018


spatel added inline comments.


================
Comment at: llvm/trunk/test/Transforms/InstCombine/select-and-cmp.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -instcombine -S | FileCheck %s
 
----------------
xbolva00 wrote:
> spatel wrote:
> > The code was moved to instsimplify, but the tests remained in instcombine. The files should be moved, and the RUN lines should be changed to only use "-instsimplify".
> Move them directly to test/Analysis? There are many inner folders - is there any folder which is more suitable for this tests?
instsimplify tests are under:
test/Transforms/InstSimplify

I think that's because instsimplify can be used as either an analysis or a transform pass.


Repository:
  rL LLVM

https://reviews.llvm.org/D49919





More information about the llvm-commits mailing list