[PATCH] D49884: [MachineOutliner] Add support for saving LR to a callee-saved register

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 17:13:54 PDT 2018


MatzeB added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:4952
+  // We only want callee-saved registers that were saved in the Candidate's
+  // frame.
+  const std::vector<CalleeSavedInfo> &CSInfo =
----------------
paquette wrote:
> efriedma wrote:
> > Why not a caller-save register?
> I talked with Matthias about this, and apparently LiveRegUnits actually handles basically everything weird that could happen here, so it's not even really an issue...
Meaning we can change this to just go over the whole GPR register class instead of the CSR list :)


https://reviews.llvm.org/D49884





More information about the llvm-commits mailing list