[PATCH] D49946: Fix crash in bounds checking

Joel Galenson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 15:54:04 PDT 2018


jgalenson created this revision.
jgalenson added reviewers: eugenis, Ka-Ka.
Herald added subscribers: llvm-commits, javed.absar.

In r337830 I added SCEV checks to enable us to insert fewer bounds checks.  Unfortunately, this sometimes crashes when multiple bounds checks are added due to SCEV caching issues.  This patch splits the bounds checking pass into two phases, one that computes all the conditions (using SCEV checks) and the other that adds the new instructions.


Repository:
  rL LLVM

https://reviews.llvm.org/D49946

Files:
  lib/Transforms/Instrumentation/BoundsChecking.cpp
  test/Instrumentation/BoundsChecking/many-traps-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49946.157794.patch
Type: text/x-patch
Size: 6467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180727/a96c555a/attachment.bin>


More information about the llvm-commits mailing list