[PATCH] D49912: [X86] MCA tests for XCHG* and CMPXCHG* instructions

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 06:27:52 PDT 2018


avt77 added inline comments.


================
Comment at: test/tools/llvm-mca/X86/Atom/resources-x86_64.s:676-677
+xchgb %bl, %cl
+xchgb %al, (%rbx)
+xchgb %bl, (%rbx)
+
----------------
lebedev.ri wrote:
> http://felixcloutier.com/x86/XCHG.html suggests that memory operand can be on either side,
> so this needs to be repeated with swapped order.
In fact I checked it but decided not to include in the test because this test is not about syntax. But if you insist I'll extend the test. Is it enough to include the check in one test file only? I mean that I'd like to check this syntax construction for one cpu, OK? Or you'd like to see it inside all 10 files?


https://reviews.llvm.org/D49912





More information about the llvm-commits mailing list